Implement topology awareness support for dynamic provisioning #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 29
💛 - Coveralls |
|
Build will be fixed by #43 |
leakingtapan
force-pushed
the
topology
branch
2 times, most recently
from
4fe248f to
04a7c34
Compare
bertinatto
reviewed
Oct 8, 2018
There was a problem hiding this comment.
Just a few minor observations, but in general it LGTM. Needs a rebase, though.
We also need an e2e test for this functionality. It can be implemented in another PR, though. Here's an example from GCP: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/e2e/tests/multi_zone_e2e_test.go
k8s-ci-robot
added
the
lgtm
bertinatto
removed
the
lgtm
leakingtapan
force-pushed
the
topology
branch
2 times, most recently
from
463336e to
a20fb44
Compare
added 3 commits
October 9, 2018 22:04
Changes includes:
1. return topology in NodeGetInfo response eg. accessible_topology =
{"com.amazon.aws.csi.ebs/zone": "us-west-2a"}
2. consumes topology requirement in CreateVolume request and creates
volume using the given zone while favoring preferred topologies
3. pick a random zone when topology requirement is not provided
(this is the case of dynamic provisioning without delayed binding)
4. Add unit test for pickAvailabilityZone()
5. Add test case for CreateDisk with zone
populate context for `DescribeAvailabilityZonesWithContext`
leakingtapan
force-pushed
the
topology
branch
from
a20fb44 to
7d48363
Compare
|
Addressed the comments and also rebased |
|
/lgtm This is awesome, thank you for implementing this. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes includes:
{"com.amazon.aws.csi.ebs/zone": "us-west-2a"}
volume using the given zone while favoring preferred topologies
(this is the case of dynamic provisioning without delayed binding)
Fixes: #17